Re: [PATCH] overlay: test ro/rw fd data inconsistecies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 5, 2016 at 1:10 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> On Fri, Dec 02, 2016 at 10:13:33AM +0200

...
>
> ... it's just an unexpected interaction with common functionality
> provided by libxcmd that is present to support xfs_quota
> requirements, not xfs_io. Hence there's every chance that it's use
> in xfs_io is simply incorrect and never intended, and you're the
> first person to ever trip over it.
>
> The solution may simply be that we add CMD_FLAG_GLOBAL to
> every command in xfs_io, but I'm not sure yet.
>
>> If you have a preference for solution I can execute the work.
>
> Always fix the broken tool first.
>

The question was if I need to fix the run command per file or kill it.

Anyway, I came up with a very simple patch that enabled running
xfs_io -c <cmd> without any <file> args.
In that case, it is easy to understand what the user wants and commands
are just run once as if they where input in the interactive shell.

This is good enough for my test case and should be a good change
for xfs_io all in all.

Patch on its way.

I will let you decide how to handle the undocumented/unused/broken
case of multiple files and "open" command.

Amir.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux