On Thu, Nov 24, 2016 at 10:12 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
> Introduce a new test to demonstrates a known issue with overlayfs:
> - process A opens file F for read
> - process B writes new data to file F
> - process A reads old data from file F
>
> This issue is about to be fixed with a patch set by Miklos Szeredi.
Eryu and all,
I wanted to ask what is the common practice for introducing tests for
know issues
that are *about* to be solved.
What is the preferred timing for merging these sort of tests?
Is it productive to have these tests merged before a fix is merged to master?
Before a fix is queued for next?
Before a fix is available?
I am asking because there are several known issues for overlayfs
whose fixes are in several different states of maturity and I would like
to know how to treat the tests I write for them.
FYI, the fix for the test in this patch (test ro/rw fd data inconsistencies)
is not queued for next yet, but I am hoping it will be.
Miklos?
>
> Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>
> ---
> tests/overlay/016 | 98 +++++++++++++++++++++++++++++++++++++++++++++++++++
> tests/overlay/016.out | 12 +++++++
> tests/overlay/group | 1 +
> 3 files changed, 111 insertions(+)
> create mode 100755 tests/overlay/016
> create mode 100644 tests/overlay/016.out
>
> diff --git a/tests/overlay/016 b/tests/overlay/016
> new file mode 100755
> index 0000000..6d3e339
> --- /dev/null
> +++ b/tests/overlay/016
> @@ -0,0 +1,98 @@
> +#! /bin/bash
> +# FSQA Test No. 016
> +#
> +# Test ro/rw fd data inconsistecies
> +#
> +# This simple test demonstrates a known issue with overlayfs:
> +# - process A opens file F for read
> +# - process B writes new data to file F
> +# - process A reads old data from file F
> +#
> +#-----------------------------------------------------------------------
> +#
> +# Copyright (C) 2016 CTERA Networks. All Rights Reserved.
> +# Author: Amir Goldstein <amir73il@xxxxxxxxx>
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it would be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write the Free Software Foundation,
> +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> +#-----------------------------------------------------------------------
> +#
> +
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# real QA test starts here
> +_supported_fs overlay
> +_supported_os Linux
> +_require_scratch
> +
> +rm -f $seqres.full
> +
> +_scratch_mkfs >>$seqres.full 2>&1
> +
> +# Create our test files.
> +lowerdir=$SCRATCH_DEV/$OVERLAY_LOWER_DIR
> +mkdir -p $lowerdir
> +echo "This is old news" > $lowerdir/foo
> +echo "This is old news" > $lowerdir/bar
> +
> +_scratch_mount
> +
> +cd $SCRATCH_MNT
> +
> +#
> +# case #1:
> +# open file for read (rofd)
> +# open file for write (rwfd)
> +# write to rwfd
> +# read from rofd
> +#
> +$XFS_IO_PROG << EOF | _filter_xfs_io
> +open -r foo
> +open foo
> +pwrite -S 0x61 0 16
> +file 0
> +pread -v 0 16
> +EOF
> +
> +#
> +# case #2:
> +# mmap MAP_SHARED|PROT_READ of rofd
> +# write to rwfd
> +# read from mapped memory
> +#
> +$XFS_IO_PROG << EOF | _filter_xfs_io
> +open -r bar
> +mmap -r 0 16
> +open bar
> +pwrite -S 0x61 0 16
> +mread -v 0 16
> +EOF
> +
> +status=0
> +exit
> diff --git a/tests/overlay/016.out b/tests/overlay/016.out
> new file mode 100644
> index 0000000..52b8cd7
> --- /dev/null
> +++ b/tests/overlay/016.out
> @@ -0,0 +1,12 @@
> +QA output created by 016
> +xfs_io> xfs_io> xfs_io> wrote 16/16 bytes at offset 0
> +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +xfs_io> [000] foo (foreign,non-sync,non-direct,read-only)
> + 001 foo (foreign,non-sync,non-direct,read-write)
> +xfs_io> 00000000: 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61 aaaaaaaaaaaaaaaa
> +read 16/16 bytes at offset 0
> +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +xfs_io> xfs_io> xfs_io> xfs_io> xfs_io> wrote 16/16 bytes at offset 0
> +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +xfs_io> 00000000: 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61 aaaaaaaaaaaaaaaa
> +xfs_io>
> \ No newline at end of file
> diff --git a/tests/overlay/group b/tests/overlay/group
> index 84850b1..5740d2a 100644
> --- a/tests/overlay/group
> +++ b/tests/overlay/group
> @@ -18,3 +18,4 @@
> 013 auto quick
> 014 auto quick copyup
> 015 auto quick whiteout
> +016 auto quick
> --
> 2.7.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
