On Wed, Nov 23, 2016 at 12:55:51AM +0000, David Howells wrote: > -int vfs_getattr_nosec(struct path *path, struct kstat *stat) > +int vfs_xgetattr_nosec(struct path *path, struct kstat *stat) const struct path *, please. Especially since we feed &file->f_path to it. And yes, I realize that the same applies to vfs_getattr() in the current tree. > +int vfs_xgetattr(struct path *path, struct kstat *stat) Ditto. > +int vfs_getattr(struct path *path, struct kstat *stat) Again. > +#define __put_timestamp(kts, uts) ( \ > + __put_user(kts.tv_sec, uts.tv_sec ) || \ > + __put_user(kts.tv_nsec, uts.tv_nsec ) || \ > + __put_user(0, uts.__reserved )) static inline. > +#define KSTAT_ATTR_FS_IOC_FLAGS 0x00000874 /* Attrs corresponding to FS_*_FL flags */ Err... An explicit hex constant? -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html