Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andreas Dilger <adilger@xxxxxxxxx> wrote:

> > +		case S_IFCHR:	printf(" character special file\n");	ft = 'c'; break;
> 
> This will overflow 80 columns.  Could use just "character special"?
> 
> > +		case S_IFDIR:	printf(" directory\n");			ft = 'd'; break;
> > +		case S_IFBLK:	printf(" block special file\n");	ft = 'b'; break;
> > +		case S_IFREG:	printf(" regular file\n");		ft = '-'; break;
> > +		case S_IFLNK:	printf(" symbolic link\n");		ft = 'l'; break;
> 
> Having these all as single-word items would make it easier to parse for
> test programs.  Same with "IO Block:" -> "Blocksize:".  Not a huge deal.

Try doing "stat /dev/null".

David
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux