On Mon 17-10-16 11:40:42, Ross Zwisler wrote: > On Tue, Sep 27, 2016 at 06:08:13PM +0200, Jan Kara wrote: > > + /* Did we COW the page? */ > > + if (vmf->flags & FAULT_FLAG_WRITE && !(vmf->vma->vm_flags & VM_SHARED)) > > Oh, sorry, I did have one bit of feedback. Maybe added parens around the flag > check for readability: > > if ((vmf->flags & FAULT_FLAG_WRITE) && !(vmf->vma->vm_flags & VM_SHARED)) Fixed. > Aside from that one nit: > > Reviewed-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx> Thanks! Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
