Re: [PATCH] xfs: don't take the IOLOCK exclusive for direct I/O page invalidation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon 17-10-16 14:13:12, Christoph Hellwig wrote:
> XFS historically took the iolock exclusive when invalidating pages
> before direct I/O operations to protect against writeback starvations.
> 
> But this writeback starvation issues has been fixed a long time ago
> in the core writeback code, and all other file systems manage to do
> without the exclusive lock.  Convert XFS over to avoid the exclusive
> lock in this case, and also move to range invalidations like done
> by the other file systems.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

The patch looks good to me. You can add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux