Hi, On Mon, 2007-08-20 at 09:46 -0600, Matthew Wilcox wrote: > Do you still want to keep J_ASSERT, or should all uses of it be replaced > with BUG_ON? > > (to put it another way; if you were writing JBD now, would you add your > own J_ASSERT, or would you just use BUG_ON directly?) The _BH and _JH variants I'd keep, as they allow developers to hook state debugging printks into the output easily. J_ASSERT itself... I wouldn't think I'd bother reinventing BUG_ON these days. --Stephen - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html