Re: [RFC PATCH 0/2] avoid clobbering registers with J_ASSERT macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 2007-08-20 at 09:18 -0400, Chris Snook wrote:

> > How's about we just remove that printk?  Do
> > 
> > #define J_ASSERT(e) BUG_ON(e)?
> > 
> > The rest of the kernel seems to be able to cope with that...
> 
> Perfectly fine with me.  I proposed the conditional on the grounds that someone 
> probably had a purpose for the original J_ASSERT macro at some point in history, 
> but if that purpose is long since obsolete, let's just get rid of it.  I'll repost.

It did.  The original J_ASSERT predates BUG() entirely, and was added so
that we got the file/line-no information.  But with the current BUG()
macro, I can't see any reason for J_ASSERT still to try to gather that
information itself.

--Stephen


-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux