On Sat, 2007-06-30 at 10:39 +0100, Christoph Hellwig wrote: > On Mon, Jun 25, 2007 at 08:19:52AM -0700, Dave Hansen wrote: > > > Should we just take the calls outside the switch statement? > > > > Yeah, that's much better. I assume we don't care whether we're getting > > -EROFS or -EPERM/-EINVAL for the S_IFDIR and default cases? > > We need to keep the exact error returns, so you'll have to add some > special case checks before the r/o check. It's probably still cleaner, > though. I'm looking through this and having a really hard time seeing any nice ways to make this cleaner. Were you thinking of basically a duplicate case statement before the r/w check? -- Dave - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
