On Fri, Apr 06, 2007 at 06:46:18PM +0100, Christoph Hellwig wrote: > On Thu, Apr 05, 2007 at 07:40:53PM -0400, J. Bruce Fields wrote: > > diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c > > index f52cf5c..d557a51 100644 > > --- a/fs/nfs/nfs4proc.c > > +++ b/fs/nfs/nfs4proc.c > > @@ -3019,6 +3019,8 @@ static int _nfs4_proc_getlk(struct nfs4_state *state, int cmd, struct file_lock > > status = 0; > > } > > out: > > + if (request->fl_ops) > > + request->fl_ops->fl_release_private(request); > > Don't we know which fl_release_private instace we'll call and could > do a direct call instead? Yeah. It's currently private to another file, but that could obviously be fixed. The fl_ops check is still required, though. I could go either way. --b. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
