Matthew Wilcox wrote:
I know that the rsync load is a major factor on kernel.org right now.
That should be quite easy to quantify then. Move the readdir and stat call next to each other in the sources, pass the struct stat around if necessary, and then count the stat calls which do not originate from the stat following the readdir call. Of course we'll also need the actual improvement which can be achieved by combining the calls. Given the inodes are cached, is there more overhead then finding the right inode? Note that is rsync doesn't already use fstatat() it should do so and this means then that there is no long file path to follow, all file names are local to the directory opened with opendir().
My but feeling is that the improvements are minimal for normal (not cluster etc) filesystems and hence the improvements for kernel.org would be minimal.
-- ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖ - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
