On Thu, 2006-12-07 at 11:21 -0500, J. Bruce Fields wrote:
> On Thu, Dec 07, 2006 at 07:43:48AM -0800, Marc Eshel wrote:
> > nfs-bounces@xxxxxxxxxxxxxxxxxxxxx wrote on 12/07/2006 07:23:59 AM:
> >
> > > On Wed, Dec 06, 2006 at 10:47:46PM -0800, Marc Eshel wrote:
> > > > if (!rv) { /* got fs lock */
> > > > rv = posix_lock_file(file, fl);
> > > > if (rv) { /* did not get posix lock */
> > >
> > > If we never request the local lock until after we've gotten the lock
> > > from GFS, then this should never happen. So I think this could just be
> > > a BUG_ON(rv)--except that would mean a failure in the lock manager could
> > > oops the kernel, so maybe it'd be better just to printk.
> >
> > It can happen if you can not allocate memory.
>
> OK, you're right.
>
> Hm, the NFS client just seems to print out a warning at this point,
> though.
Feel free to suggest alternatives. If you cannot even allocate the
memory necessary to add a struct file_lock, then how can you expect to
find enough resources to be able to marshall up an RPC call?
Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
