On Fri, Oct 13 2006, Andrew Morton wrote: > On Fri, 13 Oct 2006 09:45:17 +0200 > Jens Axboe <jens.axboe@xxxxxxxxxx> wrote: > > > > Compile tested only. I probably won't get a chance to actually run it until > > > late this weekend at the earliest :/ > > > > Patch looks ok to me. The double lock test only works, as long as splice > > is the only one ever locking both mutexes. Or if others follow the same > > ordering rules. I'm not very well versed in vfs matters, is that > > guarenteed? > > Taking the lowest-addressed lock first is the usual convention, if we really > have to do that. I'm not aware of anywhere else where we pull this > trick with i_mutex though. It is, but people had concerns with that approach when it was originally done for pipe tee'ing. Things like lock_rename() look scary. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
