Hi, generic_file_splice_write() will call into a file systems ->prepare_write() and ->commit_write() via the the pipe_to_file() actor. pipe_to_file() is careful to take the pipe inode i_mutex, but nowhere in the call path do I see i_mutex on the inode being written to taken. Shouldn't we be taking this before calling into ->prepare_write() and ->commit_write(). What's preventing generic_file_splice_write() from racing a truncate? Or maybe even another write? A quick look through other callers reveals that generic_file_aio_write() and do_lo_send_aops() both are careful to take i_mutex. Thanks, --Mark -- Mark Fasheh Senior Software Developer, Oracle mark.fasheh@xxxxxxxxxx - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
