On Thu, 7 Sep 2006 20:25:32 +0900 Tetsuo Handa wrote: > Hello. > > The prototype of do_truncate() looks misleading. > > ----- Start of patch ----- > diff -ur linux-2.6.18-rc6-org/include/linux/fs.h linux-2.6.18-rc6-new/include/linux/fs.h > --- linux-2.6.18-rc6-org/include/linux/fs.h 2006-09-04 12:53:15.000000000 +0900 > +++ linux-2.6.18-rc6-new/include/linux/fs.h 2006-09-07 16:18:23.000000000 +0900 > @@ -1418,7 +1418,7 @@ > > /* fs/open.c */ > > -extern int do_truncate(struct dentry *, loff_t start, unsigned int time_attrs, > +extern int do_truncate(struct dentry *, loff_t length, unsigned int time_attrs, > struct file *filp); Since we (mostly) prefer to have parameter variable names in prototypes and 3 of those 4 already do that, please add a variable name for the "struct dentry *" also... Thanks. > extern long do_sys_open(int fdf, const char __user *filename, int flags, > int mode); > ----- End of patch ----- > > Yeah, ptototypo is prototype + typo :) --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
