Re: [PATCH] reiserfs:fix journaling issue regarding fsync()

["Hisashi Hifumi" <hifumi.hisashi@xxxxxxxxxxxxx>]

Hi.

> This is correct, excpet you need to put the update_inode_transaction call
> inside reiserfs_write_lock/unlock.

Again, I remade my patch.
I have a question.
I understand update_inode_transaction must be inside reiserfs_write_lock.
Is update_inode_transaction needed to be inside journal_begin/end ?


Signed-off-by :Hisashi Hifumi <hifumi.hisashi@xxxxxxxxxxxxx>

diff -Nru linux-2.6.17/fs/reiserfs/file.c linux-2.6.17_fix/fs/reiserfs/file.c
--- linux-2.6.17/fs/reiserfs/file.c     2006-06-18 10:49:35.000000000 +0900
+++ linux-2.6.17_fix/fs/reiserfs/file.c 2006-07-01 07:39:11.002239042 +0900
@@ -860,8 +860,12 @@
                        // this sets the proper flags for O_SYNC to
trigger a commit
                        mark_inode_dirty(inode);
                        reiserfs_write_unlock(inode->i_sb);
-               } else
+               } else {
+                       reiserfs_write_lock(inode->i_sb);
+                       reiserfs_update_inode_transaction(inode);
                        mark_inode_dirty(inode);
+                       reiserfs_write_unlock(inode->i_sb);
+               }

                sd_update = 1;
        }


-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html