On Tuesday 20 June 2006 04:43, Hisashi Hifumi wrote: > Hi, > > When write() extends a file(i_size is increased) and fsync() is > called, change of inode must be written to journaling area > through fsync(). > But,currently the i_trans_id is not correctly updated when i_size > is increased. So fsync() does not kick the journal writer. Thanks for the patch. One problem is this will bump the transaction marker for atime updates too. I'd rather see the change done inside reiserfs_file_write. reiserfs_file_write already updates the transaction when blocks are allocated, but you're right that to be 100% correct we should cover the case when i_size increases but new blocks are not added. Was this the case you were trying to fix? -chris - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
