Re: [PATCH v2 3/4] blk-crypto: remove blk_crypto_insert_cloned_request()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2 3/4] blk-crypto: remove blk_crypto_insert_cloned_request()
From: Eric Biggers <ebiggers@xxxxxxxxxx>
Date: Wed, 15 Mar 2023 11:27:15 -0700
In-reply-to: <ZBHxJK+MAGIBmHOU@infradead.org>
References: <20230308193645.114069-1-ebiggers@kernel.org> <20230308193645.114069-4-ebiggers@kernel.org> <ZBHxJK+MAGIBmHOU@infradead.org>

On Wed, Mar 15, 2023 at 09:24:04AM -0700, Christoph Hellwig wrote:
> > -	if (blk_crypto_insert_cloned_request(rq))
> > +	if (blk_crypto_rq_get_keyslot(rq))
> >  		return BLK_STS_IOERR;
> 
> Wouldn't it be better to propagate the actual error from
> blk_crypto_rq_get_keyslot?
> 

I'll add a patch that does that.

- Eric

References:
- [PATCH v2 0/4] Fix blk-crypto keyslot race condition
  - From: Eric Biggers
- [PATCH v2 3/4] blk-crypto: remove blk_crypto_insert_cloned_request()
  - From: Eric Biggers
- Re: [PATCH v2 3/4] blk-crypto: remove blk_crypto_insert_cloned_request()
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH v2 2/4] blk-crypto: make blk_crypto_evict_key() more robust
Next by Date: [PATCH v3 0/6] Fix blk-crypto keyslot race condition
Previous by thread: Re: [PATCH v2 3/4] blk-crypto: remove blk_crypto_insert_cloned_request()
Next by thread: [RFC PATCH 0/2] ceph: fscrypt: fix atomic open bug for encrypted directories
Index(es):
- Date
- Thread

[Index of Archives] [linux Cryptography] [Asterisk App Development] [PJ SIP] [Gnu Gatekeeper] [IETF Sipping] [Info Cyrus] [ALSA User] [Fedora Linux Users] [Linux SCTP] [DCCP] [Gimp] [Yosemite News] [Deep Creek Hot Springs] [Yosemite Campsites] [ISDN Cause Codes]

Powered by Linux