Re: [PATCH v2 3/4] blk-crypto: remove blk_crypto_insert_cloned_request()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Eric Biggers <ebiggers@xxxxxxxxxx>
Subject: Re: [PATCH v2 3/4] blk-crypto: remove blk_crypto_insert_cloned_request()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 15 Mar 2023 09:24:04 -0700
In-reply-to: <20230308193645.114069-4-ebiggers@kernel.org>
References: <20230308193645.114069-1-ebiggers@kernel.org> <20230308193645.114069-4-ebiggers@kernel.org>

> -	if (blk_crypto_insert_cloned_request(rq))
> +	if (blk_crypto_rq_get_keyslot(rq))
>  		return BLK_STS_IOERR;

Wouldn't it be better to propagate the actual error from
blk_crypto_rq_get_keyslot?

Follow-Ups:
- Re: [PATCH v2 3/4] blk-crypto: remove blk_crypto_insert_cloned_request()
  - From: Eric Biggers

References:
- [PATCH v2 0/4] Fix blk-crypto keyslot race condition
  - From: Eric Biggers
- [PATCH v2 3/4] blk-crypto: remove blk_crypto_insert_cloned_request()
  - From: Eric Biggers

Prev by Date: Re: [PATCH v2 2/4] blk-crypto: make blk_crypto_evict_key() more robust
Next by Date: Re: [PATCH v2 4/4] blk-crypto: drop the NULL check from blk_crypto_put_keyslot()
Previous by thread: [PATCH v2 3/4] blk-crypto: remove blk_crypto_insert_cloned_request()
Next by thread: Re: [PATCH v2 3/4] blk-crypto: remove blk_crypto_insert_cloned_request()
Index(es):
- Date
- Thread

[Index of Archives] [linux Cryptography] [Asterisk App Development] [PJ SIP] [Gnu Gatekeeper] [IETF Sipping] [Info Cyrus] [ALSA User] [Fedora Linux Users] [Linux SCTP] [DCCP] [Gimp] [Yosemite News] [Deep Creek Hot Springs] [Yosemite Campsites] [ISDN Cause Codes]

Powered by Linux