On Sat, Dec 05, 2020 at 12:28:08PM +0000, Satya Tangirala wrote:
> > +#define CQHCI_CRYPTO_CONFIGURATION_ENABLE (1 << 7)
> > +#define CQHCI_CRYPTO_KEY_MAX_SIZE 64
> > +/* x-CRYPTOCFG - Crypto Configuration X */
> > +union cqhci_crypto_cfg_entry {
> > + __le32 reg_val[32];
> > + struct {
> > + u8 crypto_key[CQHCI_CRYPTO_KEY_MAX_SIZE];
> > + /* 4KB/512 = 8 */
> I'm not sure what this comment is for (admittedly, it seems I introduced
> this line into AOSP, and that seems to have made it here haha) - I think
> we should just remove it.
> > + u8 data_unit_size;
> > + u8 crypto_cap_idx;
> > + u8 reserved_1;
> > + u8 config_enable;
> > + u8 reserved_multi_host;
> > + u8 reserved_2;
> > + u8 vsb[2];
> > + u8 reserved_3[56];
> > + };
> > +};
(Please quote just the part that you're actually replying to -- thanks!)
The comment gives the typical value that is stored in data_unit_size,
but yeah it's a bad comment. I'll just remove it.
- Eric
|