On Sat, Dec 05, 2020 at 12:33:40PM +0000, Satya Tangirala wrote: > > The version of code from Qualcomm on AOSP reprogrammed all keyslots from > > cqhci_recovery_finish(). I notice that this patch drops that - I'm guessing > > that was intentional? Other than that, this patch looks good to me :). > For reference, the code I'm referring to is at > https://android-review.googlesource.com/c/kernel/common/+/1269702/9 Yes, it's intentional. Reprogramming the keys should only be needed when the hardware is reset, which patch 1 handles via mmc_set_initial_state(). The CQE recovery procedure normally just "stops" the hardware, not reset it. So cqhci_recovery_finish() doesn't seem like the right place to reprogram the keys. - Eric
|