Re: [fsverity-utils PATCH v2 2/4] lib/compute_digest: add default hash_algorithm and block_size

[Luca Boccassi <Luca.Boccassi@xxxxxxxxxxxxx>]

On Mon, 2020-11-16 at 12:56 -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> If hash_algorithm is left 0, default it to FS_VERITY_HASH_ALG_SHA256;
> and if block_size is left 0, default it to 4096 bytes.
> 
> While it's nice to be explicit, having defaults makes things easier for
> library users.
> 
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> ---
>  include/libfsverity.h          | 47 ++++++++++++++++++++++++++--------
>  lib/compute_digest.c           | 27 +++++++++++--------
>  lib/lib_private.h              |  6 +++++
>  programs/cmd_digest.c          |  8 +-----
>  programs/cmd_sign.c            |  9 +------
>  programs/test_compute_digest.c | 18 ++++++++-----
>  6 files changed, 71 insertions(+), 44 deletions(-)

Acked-by: Luca Boccassi <luca.boccassi@xxxxxxxxxxxxx>

-- 
Kind regards,
Luca Boccassi

Attachment: signature.asc
Description: This is a digitally signed message part