On Mon, 2020-11-16 at 12:56 -0800, Eric Biggers wrote: > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > Even though the kernel currently only supports PAGE_SIZE == Merkle tree > block size, PAGE_SIZE isn't a good default Merkle tree block size for > fsverity-utils, since it means that if someone doesn't explicitly > specify the block size, then the results of 'fsverity sign' and > 'fsverity enable' will differ between different architectures. > > So change the default Merkle tree block size to 4096, which is the most > common PAGE_SIZE. This will break anyone using the fsverity program > without the --block-size option on an architecture with a non-4K page > size. But I don't think anyone is actually doing that yet anyway. > > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> > --- > programs/cmd_digest.c | 2 +- > programs/cmd_enable.c | 2 +- > programs/cmd_sign.c | 2 +- > programs/fsverity.c | 14 -------------- > programs/fsverity.h | 1 - > 5 files changed, 3 insertions(+), 18 deletions(-) Acked-by: Luca Boccassi <luca.boccassi@xxxxxxxxxxxxx> -- Kind regards, Luca Boccassi
Attachment:
signature.asc
Description: This is a digitally signed message part
|