On Mon, 2025-03-17 at 08:26 +0300, Dan Carpenter wrote: > On Thu, Mar 13, 2025 at 03:14:48PM +0000, Nuno Sá wrote: > > @@ -224,8 +226,8 @@ static void axi_clkgen_calc_clk_params(unsigned int > > divider, > > > > if (params->edge == 0 || frac_divider == 1) > > params->low--; > > - if (((params->edge == 0) ^ (frac_divider == 1)) || > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > - (divider == 2 && frac_divider == 1)) > > + if ((params->edge == 0 ^ frac_divider == 1) || > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > This works, but the code was a lot easier to read with parentheses. > > Yes, I'll do it in v3. Just waiting a few more days for additional comments. - Nuno Sá
