Re: [PATCH v2 6/6] clk: clk-axi-clkgen: fix coding style issues

[Dan Carpenter <dan.carpenter@xxxxxxxxxx>]

On Thu, Mar 13, 2025 at 03:14:48PM +0000, Nuno Sá wrote:
> @@ -224,8 +226,8 @@ static void axi_clkgen_calc_clk_params(unsigned int divider,
>  
>  		if (params->edge == 0 || frac_divider == 1)
>  			params->low--;
> -		if (((params->edge == 0) ^ (frac_divider == 1)) ||
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> -			(divider == 2 && frac_divider == 1))
> +		if ((params->edge == 0 ^ frac_divider == 1) ||
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This works, but the code was a lot easier to read with parentheses.

regards,
dan carpenter