On 03/03/2025 11:29, Ian Dannapel wrote: > Hi Krzysztof, thanks for the quick response. > > On Sat, Mar 1, 2025 at 2:13 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: >> >> On 28/02/2025 10:47, iansdannapel@xxxxxxxxx wrote: >>> + >>> + References: >>> + - https://www.efinixinc.com/docs/an006-configuring-trion-fpgas-v6.3.pdf >>> + - https://www.efinixinc.com/docs/an033-configuring-titanium-fpgas-v2.8.pdf >>> + - https://www.efinixinc.com/docs/an061-configuring-topaz-fpgas-v1.1.pdf >>> + >>> +allOf: >>> + - $ref: /schemas/spi/spi-peripheral-props.yaml# >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - efinix,trion-spi >>> + - efinix,titanium-spi >>> + - efinix,topaz-spi >> >> >> Same comments as before about compatibility. Address or implement. >> > The compatibles are implemented in the device match table, what > exactly should be addressed or implemented here? Comments from previous revision - they look compatible, so define this as list of compatibles where one is of above is used as fallback. See example schema or 90% of other bindings (oneOf:). > >>> + - efinix,fpga-spi >> >> >> And this one is for which device? It is not even used. > The proposed compatible is a generic fallback for any Efinix FPGA You do not use here fallback at all. Fallback means last compatible in the list, but you have here only one item. > Series. Isn't it used if the compatible is part of the drivers match > table? Drop, compatibles are supposed to be specific. Best regards, Krzysztof
