On Wed, Dec 25, 2024 at 10:10:06PM -0800, Yidong Zhang wrote: > > > On 3/12/23 11:03, Xu Yilun wrote: > > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > > > > On Sun, Dec 22, 2024 at 05:53:30PM -0800, Yidong Zhang wrote: > > > > > > > > > On 11/18/24 23:07, Xu Yilun wrote: > > > > > > > > > > > +obj-$(CONFIG_AMD_VERSAL_MGMT) += amd-vmgmt.o > > > > > > IMHO the naming vmgmt is hard to understand, any better idea? > > > > > The "v" stand for Versal. We would change to amd-vpci for Versal based pcie > > > > "v" + "pci" is quite a misleading term, maybe just versal-pci? > > > > > > Hi Yilun, > > > > > > I sent the V2 patch and refactored the driver as versal-pci now. > > > One more thing that I kept in V2 was the firmware_upload. I forgot to > > > mention that I'd love to switch to the newly proposed interface once > > > it is ready. I saw the proposal was now as config_fs and it was not merged > > > > Good to know that. > > > > I didn't start reviewing the v2 yet. But one thing is that now the > > versal-pci FPGA manager has no user because of the ongoing uAPI, so > > cannot be merged, and I won't pay much effort on this series for now. > > Hi Yilun, > > Can we add this as TODO in the future when the uAPI solution is ready to > switch? We spent some time to refactor the driver and address most of your Sorry, generally kernel won't merge code that has no user, which means the code are not tested. > comments in the V2. Hopefully, can you please start reviewing the fpga_mgr > and other driver code? Yes, I can review the code when possible. But will not merge it. > > We'd think that we use the firmware_upload for 1st approach and start > letting user use this driver. > > We definitely will switch to the new uAPI as soon as it is ready in the > linux fpga driver. But we'd not like this uAPI holds up everything we > already spent times. If you want speed up, then collaborate to develop/review the dependent patchset, that's how the community works. I actually don't want to be the only reviewer in this mail list, and others just send patches. Thanks, Yilun
