On Sun, Dec 22, 2024 at 05:53:30PM -0800, Yidong Zhang wrote: > > > On 11/18/24 23:07, Xu Yilun wrote: > > > > > > > +obj-$(CONFIG_AMD_VERSAL_MGMT) += amd-vmgmt.o > > > > IMHO the naming vmgmt is hard to understand, any better idea? > > > The "v" stand for Versal. We would change to amd-vpci for Versal based pcie > > "v" + "pci" is quite a misleading term, maybe just versal-pci? > > Hi Yilun, > > I sent the V2 patch and refactored the driver as versal-pci now. > One more thing that I kept in V2 was the firmware_upload. I forgot to > mention that I'd love to switch to the newly proposed interface once > it is ready. I saw the proposal was now as config_fs and it was not merged Good to know that. I didn't start reviewing the v2 yet. But one thing is that now the versal-pci FPGA manager has no user because of the ongoing uAPI, so cannot be merged, and I won't pay much effort on this series for now. Thanks, Yilun > yet. > > Happy Holidays. > > Thanks, > David