Re: [PATCH v4 19/19] fpga: dfl: destroy/recreate feature platform device on port release/assign

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 25, 2024 at 06:37:14PM -0400, Peter Colberg wrote:
> From: Xu Yilun <yilun.xu@xxxxxxxxx>
> 
> Now that the internal DFL APIs have been converted to consume DFL
> enumeration info from a separate structure, dfl_feature_dev_data, which
> lifetime is independent of the feature device, proceed to completely
> destroy and recreate the feature platform device on port release and
> assign, respectively. This resolves a longstanding issue in the use of
> platform_device_add(), which states to "not call this routine more than
> once for any device structure" and which used to print a kernel warning.
> 
> The function feature_dev_unregister() resets the device pointer in the
> feature data to NULL to signal that the feature platform device has been
> destroyed. This substitutes the previous device_is_registered() checks.

Acked-by: Xu Yilun <yilun.xu@xxxxxxxxx>

for this patch and all other patches that I didn't comment in this
series.

Thanks.

> 
> Signed-off-by: Xu Yilun <yilun.xu@xxxxxxxxx>
> Signed-off-by: Russ Weight <russell.h.weight@xxxxxxxxx>
> Signed-off-by: Peter Colberg <peter.colberg@xxxxxxxxx>
> Reviewed-by: Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx>
> Reviewed-by: Basheer Ahmed Muddebihal <basheer.ahmed.muddebihal@xxxxxxxxxxxxxxx>




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux