On Fri, Oct 25, 2024 at 06:37:10PM -0400, Peter Colberg wrote: > Use binfo->type instead of binfo->feature_dev to decide whether a > feature device was detected during feature parsing. A subsequent > commit will delay the allocation of the feature platform device > to feature_dev_register() and remove binfo->feature_dev. > > This commit does not introduce any functional changes. > > Signed-off-by: Peter Colberg <peter.colberg@xxxxxxxxx> > Reviewed-by: Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx> > Reviewed-by: Basheer Ahmed Muddebihal <basheer.ahmed.muddebihal@xxxxxxxxxxxxxxx> > --- > Changes since v3: > - New patch extracted from last patch of v3 series. > --- > drivers/fpga/dfl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c > index 758673b0290a..a9ec37278b2d 100644 > --- a/drivers/fpga/dfl.c > +++ b/drivers/fpga/dfl.c > @@ -1248,7 +1248,7 @@ static int parse_feature_port_afu(struct build_feature_devs_info *binfo, > return create_feature_instance(binfo, ofst, size, FEATURE_ID_AFU); > } > > -#define is_feature_dev_detected(binfo) (!!(binfo)->feature_dev) > +#define is_feature_dev_detected(binfo) ((binfo)->type != DFL_ID_MAX) I still doesn't get why put the change here. How it resolves my concern compared to v3? Thanks, Yilun > > static int parse_feature_afu(struct build_feature_devs_info *binfo, > resource_size_t ofst) > -- > 2.47.0 > >
