Re: [PATCH v6 3/4] fpga: xilinx-selectmap: add new driver

[Xu Yilun <yilun.xu@xxxxxxxxxxxxxxx>]

> +static int xilinx_selectmap_write(struct xilinx_fpga_core *core,
> +				  const char *buf, size_t count)
> +{
> +	struct xilinx_selectmap_conf *conf = to_xilinx_selectmap_conf(core);
> +	u32 i;

comparing u32 with size_t is problematic.

size_t i;

I can fix it in place.

Thanks,
Yilun

> +
> +	for (i = 0; i < count; ++i)
> +		writeb(buf[i], conf->base);
> +
> +	return 0;
> +}