On 5/16/21 10:30 PM, Greg KH wrote: > On Sun, May 16, 2021 at 07:31:56PM -0700, Moritz Fischer wrote: >> From: Russ Weight <russell.h.weight@xxxxxxxxx> >> >> Create a platform driver that can be invoked as a sub >> driver for the Intel MAX10 BMC in order to support >> secure updates. This sub-driver will invoke an >> instance of the FPGA Security Manager class driver >> in order to expose sysfs interfaces for managing and >> monitoring secure updates to FPGA and BMC images. > No, please NEVER create a platform device for something that is not > actually a platform device. That's a huge abuse of the platform device > code. > > Please use the proper api for this if you need it, hint, it's NOT the > platform device code. Your Intel reviewer should have told you what > it is when they saw a changelog comment like this.... I was following the design of the n3000bmc-hwmon driver, which was recently accepted upstream. The MAX10 BMC driver lists sub-devices here, including my device (n3000bmc-secure) and the n3000bmc-hwmon device: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/mfd/intel-m10-bmc.c#n25 The HWMON sub-driver is implemented as a platform driver here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/hwmon/intel-m10-bmc-hwmon.c Is the HWMON driver implemented incorrectly? Or is there something fundamentally different in what I am trying to do? Can you point me in the right direction? What type of device should this be? Thanks, - Russ > > greg k-h
