On Sun, May 16, 2021 at 07:31:56PM -0700, Moritz Fischer wrote: > From: Russ Weight <russell.h.weight@xxxxxxxxx> > > Create a platform driver that can be invoked as a sub > driver for the Intel MAX10 BMC in order to support > secure updates. This sub-driver will invoke an > instance of the FPGA Security Manager class driver > in order to expose sysfs interfaces for managing and > monitoring secure updates to FPGA and BMC images. No, please NEVER create a platform device for something that is not actually a platform device. That's a huge abuse of the platform device code. Please use the proper api for this if you need it, hint, it's NOT the platform device code. Your Intel reviewer should have told you what it is when they saw a changelog comment like this.... greg k-h
