Re: [PATCH 29/43] drm/renesas/rz-du: Use fbdev-dma

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

Am 12.03.24 um 20:14 schrieb Biju Das:
Hi Thomas,

-----Original Message-----
From: Thomas Zimmermann <tzimmermann@xxxxxxx>
Sent: Tuesday, March 12, 2024 3:45 PM
To: daniel@xxxxxxxx; airlied@xxxxxxxxx; deller@xxxxxx; javierm@xxxxxxxxxx
Cc: linux-fbdev@xxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; Thomas Zimmermann
<tzimmermann@xxxxxxx>; Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
Subject: [PATCH 29/43] drm/renesas/rz-du: Use fbdev-dma

Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by
rz-du. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes.

Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

Tested-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

Thanks a lot.

I just noticed that the drivers under renesas/ don't require damage handling, so the commit message needs a change.

Best regards
Thomas


Cheers,
Biju

Cc: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
---
  drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c b/drivers/gpu/drm/renesas/rz-
du/rzg2l_du_drv.c
index 470d34da1d6c4..e5eca8691a331 100644
--- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
+++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
@@ -14,7 +14,7 @@

  #include <drm/drm_atomic_helper.h>
  #include <drm/drm_drv.h>
-#include <drm/drm_fbdev_generic.h>
+#include <drm/drm_fbdev_dma.h>
  #include <drm/drm_gem_dma_helper.h>
  #include <drm/drm_probe_helper.h>

@@ -149,7 +149,7 @@ static int rzg2l_du_probe(struct platform_device *pdev)

  	drm_info(&rcdu->ddev, "Device %s probed\n", dev_name(&pdev->dev));

-	drm_fbdev_generic_setup(&rcdu->ddev, 32);
+	drm_fbdev_dma_setup(&rcdu->ddev, 32);

  	return 0;

--
2.44.0

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)





[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux