RE: [PATCH] video: fbdev: fsl: fix kernel crash when diu_ops is not implemented

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Tue, 2015-11-24 at 12:16 -0500, Timur Tabi wrote:
> > On Tue, Nov 24, 2015 at 12:05 PM, Scott Wood <scottwood@xxxxxxxxxxxxx>
> > wrote:
> >
> > > I asked Dongsheng to put it in probe() during internal review
> > > because at the time he was printing an error, and I didn't want the
> > > error to be printed if the device wasn't present.  Again, there's
> > > another non-bugfix patch pending that moves all the rest into
> > > probe() where it belongs.
> >
> > I think it should be in _init, and not display an error.
> 
> As long as it doesn't display anything I don't care much either way.
> 

So we move the code to _init? If we are consistent I will move to _init
and send v2 patch.

Regards,
-Dongsheng
��.n��������+%������w��{.n�����{����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�

[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux