On Tue, Nov 24, 2015 at 1:27 AM, Dongsheng Wang <dongsheng.wang@xxxxxxxxxxxxx> wrote: > @@ -1697,6 +1700,9 @@ static int fsl_diu_probe(struct platform_device *pdev) > unsigned int i; > int ret; > > + if (!diu_ops.set_pixel_clock) > + return -ENODEV; > + > data = dmam_alloc_coherent(&pdev->dev, sizeof(struct fsl_diu_data), > &dma_addr, GFP_DMA | __GFP_ZERO); > if (!data) This doesn't make any sense. If set_pixel_clock() is not defined, then the whole driver aborts the probe. When could that ever happen? If the platform code does not exist, then don't let the driver be probed. -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
