On Tue, 2015-11-24 at 10:59 -0600, Scott Wood wrote: > On Tue, 2015-11-24 at 18:15 +0200, Tomi Valkeinen wrote: > > > > On 24/11/15 18:04, Timur Tabi wrote: > > > On Tue, Nov 24, 2015 at 5:46 AM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> > > > wrote: > > > > On 24/11/15 08:27, Dongsheng Wang wrote: > > > > > @@ -1697,6 +1700,9 @@ static int fsl_diu_probe(struct > > > > > platform_device > > > > > *pdev) > > > > > unsigned int i; > > > > > int ret; > > > > > > > > > > + if (!diu_ops.set_pixel_clock) > > > > > + return -ENODEV; > > > > > + > > > > > data = dmam_alloc_coherent(&pdev->dev, sizeof(struct > > > > > fsl_diu_data), > > > > > &dma_addr, GFP_DMA | __GFP_ZERO); > > > > > if (!data) > > > > > > > > > > > > > Thanks, queued for 4.5. > > > > > > Could you please wait for me to review the patch first? I am the > > > maintainer for the driver, and I see a problem with it. > > > > Sorry, I was too hasty (and tired). I thought I was looking at a patch > > that's been on the list for a while, but apparently it was only posted > > today... > > > > Anyway, dropped this. > > Also, this is a bugfix (certain platforms are currently crashing on boot) > and > once review is settled should go into 4.4. ...and stable, since the defconfig changes that enabled this driver on the problematic platforms went into 4.3. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html