RE: [PATCH] video: fbdev: fsl: fix kernel crash when diu_ops is not implemented

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Tue, Nov 24, 2015 at 11:54 AM, Timur Tabi <timur@xxxxxxxx> wrote:
> > Well, if you're concern is that there's no platform code, then there
> > should be a check that says, "see if there's any platform code", not
> > "let's check this obscure function and abort without explanation if
> > it's not initialized."
> >
> > Alternatively, why can't you just do this, in update_lcdc():
> 
> [Stupid gmail sent my message before I was done typing]
> 
> if (diu_ops.set_pixel_clock)
>    diu_ops.set_pixel_clock(var->pixclock);

Here are not friendly for kernel, because if we lost the clock we cannot
to display. We do so much things in kernel but we still cannot to display that
is before we can know it...So still think we need to check the hook in initialization
flow.

Regards,
-Dongsheng
��.n��������+%������w��{.n�����{����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�

[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux