Re: [PATCH 2/2] video: clps711x: Fix sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tue, 1 Jul 2014 09:14:02 +0300 от Tomi Valkeinen <tomi.valkeinen@xxxxxx>:
> On 28/06/14 09:34, Alexander Shiyan wrote:
> > This patch fixes below warnings:
> > CHECK   drivers/video/fbdev/clps711x-fb.c
> >   drivers/video/fbdev/clps711x-fb.c:247:24: warning: incorrect type in argument 1 (different address spaces)
> >   drivers/video/fbdev/clps711x-fb.c:247:24:    expected void const *ptr
> >   drivers/video/fbdev/clps711x-fb.c:247:24:    got char [noderef] <asn:2>*screen_base
> >   drivers/video/fbdev/clps711x-fb.c:248:35: warning: incorrect type in argument 1 (different address spaces)
> >   drivers/video/fbdev/clps711x-fb.c:248:35:    expected void const *ptr
> >   drivers/video/fbdev/clps711x-fb.c:248:35:    got char [noderef] <asn:2>*screen_base
...
> >  	info->screen_base = devm_ioremap_resource(dev, res);
> > -	if (IS_ERR(info->screen_base)) {
> > -		ret = PTR_ERR(info->screen_base);
> > +	if (IS_ERR((__force void *)info->screen_base)) {
> > +		ret = PTR_ERR((__force void *)info->screen_base);
> 
> I don't see any other user of devm_ioremap_resource() having that kind
> of casts. Why are they needed here?

Not needed, type cast was done only to remove sparse warnings.

---

��.n��������+%������w��{.n�����{����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�


[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux