Re: [PATCH 2/2] video: clps711x: Fix sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28/06/14 09:34, Alexander Shiyan wrote:
> This patch fixes below warnings:
> CHECK   drivers/video/fbdev/clps711x-fb.c
>   drivers/video/fbdev/clps711x-fb.c:247:24: warning: incorrect type in argument 1 (different address spaces)
>   drivers/video/fbdev/clps711x-fb.c:247:24:    expected void const *ptr
>   drivers/video/fbdev/clps711x-fb.c:247:24:    got char [noderef] <asn:2>*screen_base
>   drivers/video/fbdev/clps711x-fb.c:248:35: warning: incorrect type in argument 1 (different address spaces)
>   drivers/video/fbdev/clps711x-fb.c:248:35:    expected void const *ptr
>   drivers/video/fbdev/clps711x-fb.c:248:35:    got char [noderef] <asn:2>*screen_base
>   drivers/video/fbdev/clps711x-fb.c:314:17: warning: incorrect type in initializer (different address spaces)
>   drivers/video/fbdev/clps711x-fb.c:314:17:    expected void *__p
>   drivers/video/fbdev/clps711x-fb.c:314:17:    got char [noderef] <asn:2>*screen_base
> CC [M]  drivers/video/fbdev/clps711x-fb.o
> 
> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
> ---
>  drivers/video/fbdev/clps711x-fb.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/video/fbdev/clps711x-fb.c b/drivers/video/fbdev/clps711x-fb.c
> index 4d17fbb..bbf40fe 100644
> --- a/drivers/video/fbdev/clps711x-fb.c
> +++ b/drivers/video/fbdev/clps711x-fb.c
> @@ -244,8 +244,8 @@ static int clps711x_fb_probe(struct platform_device *pdev)
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>  	info->screen_base = devm_ioremap_resource(dev, res);
> -	if (IS_ERR(info->screen_base)) {
> -		ret = PTR_ERR(info->screen_base);
> +	if (IS_ERR((__force void *)info->screen_base)) {
> +		ret = PTR_ERR((__force void *)info->screen_base);

I don't see any other user of devm_ioremap_resource() having that kind
of casts. Why are they needed here?

 Tomi


Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux