On Mon, 2012-03-19 at 15:02 +0000, Mark Brown wrote:
> It is possible for regulator_enable() to fail and if it does fail that's
> generally a bad sign for anything we try to do with the hardware afterwards
> so check for and immediately return an error if regulator_enable() fails.
>
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
> .../video/omap2/displays/panel-tpo-td043mtea1.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
> index 32f3fcd..74c6b87 100644
> --- a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
> +++ b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
> @@ -272,11 +272,14 @@ static const struct omap_video_timings tpo_td043_timings = {
> static int tpo_td043_power_on(struct tpo_td043_device *tpo_td043)
> {
> int nreset_gpio = tpo_td043->nreset_gpio;
> + int r;
>
> if (tpo_td043->powered_on)
> return 0;
>
> - regulator_enable(tpo_td043->vcc_reg);
> + r = regulator_enable(tpo_td043->vcc_reg);
> + if (r != 0)
> + return r;
>
> /* wait for regulator to stabilize */
> msleep(160);
Thanks, I'll apply this series to omapdss tree.
Tomi
Attachment:
signature.asc
Description: This is a digitally signed message part
