On Wed, 2011-12-07 at 18:35 +0530, Archit Taneja wrote: > Hi, > > On Tuesday 22 November 2011 02:52 PM, Tomi Valkeinen wrote: > > Add checks for overlay and manager settings. The checks are a bit > > complex, as we need to observe the bigger picture instead of overlays > > and managers independently. Things like the used display and the zorder > > of other overlays affect the validity of the settings. > > Minor comment: > > dss_ovl_check, dss_mgr_check and dss_mgr_check_zorder don't really > qualify as functions which do actual applying of configurations, they > could be moved from apply.c to manager.c and overlay.c. I had the check functions in apply.c because they used apply.c's internal datastructures. However, looking the functions now, only dss_mgr_check_zorder() used the internal datas, and the function doesn't even use those variables for anything =). So you're right, they can be moved to manager.c and overlay.c, thanks. Tomi
Attachment:
signature.asc
Description: This is a digitally signed message part
