On 11/18/2011 04:45 AM, Zac Storer wrote: > Fixed a brace coding style issue. *sigh* You are fixing coding style, but I still get lots of warnings for the single line you are changing. IF you are fixing coding style, at least do it right. Or do you really expect me to be happy if you send me 3 patches that all touch the same line? Really, if you want to fix it, at least fix it in a way that checkpatch.pl does no longer complain about your patch, at least regarding coding style issues. And for such patches I think a per file patch or similar would be appropriate. Regards, Florian Tobias Schandinat > > Signed-off-by: Zac Storer <zac.3.14159@xxxxxxxxx> > --- > drivers/video/riva/riva_hw.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c > index 78fdbf5..c4b8a6f 100644 > --- a/drivers/video/riva/riva_hw.c > +++ b/drivers/video/riva/riva_hw.c > @@ -994,7 +994,7 @@ static void nv10CalcArbitration > clwm = clwm_mt; > */ > /* Finally, a heuristic check when width == 64 bits */ > - if(width == 1){ > + if(width == 1) { > nvclk_fill = nvclk_freq * 8; > if(crtc_drain_rate * 100 >= nvclk_fill * 102) > clwm = 0xfff; /*Large number to fail */ -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html