> On Thu, Feb 10, 2011 at 11:47:25AM +0100, Wolfram Sang wrote: > > > But I would prefer: > > > #define SET 4 > > > #define CLEAR 8 > > > [...] > > > writel(CTRL_DOTCLK_MODE, host->base + CTRL + SET) > > For this we already have __mxs_setl. > > > > > NACK. > > > > This will indeed not be caught by the compiler. > > > > And while I like the shorter macros better as well, an MXSFB_ prefix > > should be added IMO. Macros like CTRL and TIMING are not too well > > protected. > > +1 for a prefix, be it MXSFB_ or LCDIF_, will change this. > > Otherwise can we please stop about arguing about register defines? It's > too much a matter of taste and there is no perfect way to solve this. > > Sascha > Guo Shawn mmc driver's patch is good example to use mx23/mx28 register macro. Best regards Frank Li -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
