> > What about? > > Reg &= ~VDCTRL4_SET_DOTCLK_DLY(0x7); > Or? > > Reg &= ~VDCTRL4_SET_DOTCLK_DLY_MASK; > Okay, the even get longer and longer. If use 0x7, you have to take care bit width. If use VDCTRL4_SET_DOTCLK_DLY_MASK, I think BF_ and BM_ is better. > > Reg |= VDCTRL4_SET_DOTCLK_DLY(value) > > Writel(reg, offset+VDCTRL4) > > > > Compared with our macro policy. > > > > Reg = readl(offset+HW_VDCTRL4); > > Reg &=~ BM_VDCTRL4_SET_DOTCLK_DLY; > > Reg |= BF_VDCTRL4_SET_DOTCLK_DLY(value) > > Writel(reg, offset+HW_VDCTRL4) > > Anywhere else such naming policy in the kernel? I have to deal with all > kind > of CPUs, not only i.MX23/28. This driver is for mx23/mx28. I have not found such policy in the kernel, otherwise I have generated that at beginning. It is better if all of mx23/mx28 driver follow the same role. -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
