[One I never answered] On Sat, 01 May 2010 16:01:30 +0200 Florian Tobias Schandinat <FlorianSchandinat@xxxxxx> wrote: > I fear this check is wrong as > > struct viafb_par { > ... > unsigned int memsize; > ... > } > > so this check would as far as I see never return true *wonders why gcc > doesn't complain about it* That is wrong, yes. As it happens, this gets fixed later in the series when things move into via-core.c. I'd like to say that it's because I noticed the problem and dealt with it, but you're smarter than that, alas... Thanks, jon -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html