Re: [PATCH 02/30] viafb: use proper pci config API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan Corbet schrieb:
+	if (viaparinfo->memsize < 0) {
+		rc = viaparinfo->memsize;
+		goto out_delete_i2c;
+	}

I fear this check is wrong as

struct viafb_par {
	...
	unsigned int memsize;
	...
}

so this check would as far as I see never return true *wonders why gcc doesn't complain about it* Feel free to store the result in an integer or cast it back to signed or whatever solution you like.


Thanks,

Florian Tobias Schandinat
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux