question about drivers/video/au1200fb.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The code below seems suspicious.  Which definition of hi1 is
the right one?

This is not intended as a proper patch.  I can send a proper patch when I
know what to do.

julia



diff -u -p a/drivers/video/au1200fb.c b/drivers/video/au1200fb.c
--- a/drivers/video/au1200fb.c
+++ b/drivers/video/au1200fb.c
@@ -661,7 +661,6 @@ static int set_brightness(unsigned int b
 		brightness = 30;
 	}
 	divider = (lcd->pwmdiv & 0x3FFFF) + 1;
-	hi1 = (lcd->pwmhi >> 16) + 1;
 	hi1 = (((brightness & 0xFF) + 1) * divider >> 8);
 	lcd->pwmhi &= 0xFFFF;
 	lcd->pwmhi |= (hi1 << 16);
@@ -1296,7 +1295,6 @@ static void set_global(u_int cmd, struct
 			pdata->brightness = 30;
 		}
 		divider = (lcd->pwmdiv & 0x3FFFF) + 1;
-		hi1 = (lcd->pwmhi >> 16) + 1;
 		hi1 = (((pdata->brightness & 0xFF)+1) * divider >> 8);
 		lcd->pwmhi &= 0xFFFF;
 		lcd->pwmhi |= (hi1 << 16);
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux