on 12/20/2024 8:51 PM, Ojaswin Mujoo wrote: > On Thu, Dec 19, 2024 at 07:00:25PM +0800, Kemeng Shi wrote: >> The "offset" is always non-NULL, remove unneeded NULL check of "offset". >> >> Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> > > Hi Kemeng, > > I know the current callers don't pass NULL but I think we should still > keep the check around just in case, to avoid NULL dereferences in > future. I don't think there's any harm in keeping it > Sure, no insistant on this and will drop this in next version. Thanks, Kemeng > Regards, > ojaswin > >> --- >> fs/ext4/namei.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c >> index 33670cebdedc..07a1bb570deb 100644 >> --- a/fs/ext4/namei.c >> +++ b/fs/ext4/namei.c >> @@ -434,8 +434,7 @@ static struct dx_countlimit *get_dx_countlimit(struct inode *inode, >> } else >> return NULL; >> >> - if (offset) >> - *offset = count_offset; >> + *offset = count_offset; >> return (struct dx_countlimit *)(((void *)dirent) + count_offset); >> } >> >> -- >> 2.30.0 >> >
