On 2024/12/19 19:00, Kemeng Shi wrote: > The "offset" is always non-NULL, remove unneeded NULL check of "offset". > > Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> I agree with Ojaswin, the check strengthens the function, and I'd suggest that we'd better to keep it for now. Thanks, Yi. > --- > fs/ext4/namei.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c > index 33670cebdedc..07a1bb570deb 100644 > --- a/fs/ext4/namei.c > +++ b/fs/ext4/namei.c > @@ -434,8 +434,7 @@ static struct dx_countlimit *get_dx_countlimit(struct inode *inode, > } else > return NULL; > > - if (offset) > - *offset = count_offset; > + *offset = count_offset; > return (struct dx_countlimit *)(((void *)dirent) + count_offset); > } >
